Integrate pyzag bindings for neml2 #178

reverendbedford · 2024-12-10T22:47:45Z

Add pyzag wrappers for NEML2 model and include some basic tests.

This will make pyzag a dependency of NEML2.

…but no more code changes should be required

github-actions · 2024-12-10T23:03:42Z

Test Results (ubuntu-latest-Debug-ON)

3 files ±0 3 suites ±0 1m 33s ⏱️ -1s
537 tests +2 537 ✅ +3 0 💤 ±0 0 ❌ ±0
3 176 runs +2 3 176 ✅ +3 0 💤 ±0 0 ❌ ±0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-10T23:03:54Z

Documentation preview removed.
To view the documentation, please visit the main documentation page.

github-actions · 2024-12-10T23:05:13Z

Test Results (macos-latest-Debug-OFF)

3 files ±0 3 suites ±0 41s ⏱️ -1s
537 tests +2 537 ✅ +3 0 💤 ±0 0 ❌ ±0
3 176 runs +2 3 176 ✅ +3 0 💤 ±0 0 ❌ ±0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-10T23:06:19Z

Test Results (macos-latest-Release-OFF)

3 files ±0 3 suites ±0 18s ⏱️ ±0s
537 tests +2 537 ✅ +3 0 💤 ±0 0 ❌ ±0
3 174 runs +2 3 174 ✅ +3 0 💤 ±0 0 ❌ ±0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-10T23:15:44Z

Test Results (ubuntu-latest-Release-OFF)

3 files ±0 3 suites ±0 37s ⏱️ +2s
537 tests +2 537 ✅ +3 0 💤 ±0 0 ❌ ±0
3 174 runs +2 3 174 ✅ +3 0 💤 ±0 0 ❌ ±0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

hugary1995

Changes on the c++ side look okay to me. A few minor comments.

Now onto the python part...

src/neml2/models/LinearInterpolation.cxx

src/neml2/models/Model.cxx

src/neml2/models/SmoothLinearInterpolation.cxx

hugary1995

That's all my comments.

python/neml2/pyzag/interface.py

github-actions · 2024-12-11T00:08:09Z

Test Results (ubuntu-latest-Debug-OFF)

3 files ±0 3 suites ±0 1m 35s ⏱️ +5s
537 tests +2 537 ✅ +3 0 💤 ±0 0 ❌ ±0
3 176 runs +2 3 176 ✅ +3 0 💤 ±0 0 ❌ ±0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-11T01:45:51Z

Python Binding Test Results (macos-latest)

94 tests +18 70 ✅ +18 8s ⏱️ +7s
1 suites ± 0 24 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

github-actions · 2024-12-11T01:51:10Z

Python Binding Test Results (ubuntu-latest)

94 tests +18 70 ✅ +18 11s ⏱️ +10s
1 suites ± 0 24 💤 ± 0
1 files ± 0 0 ❌ ± 0

Results for commit 394b3c6. ± Comparison against base commit 53b7035.

♻️ This comment has been updated with latest results.

hugary1995

We are running out of independent reviewers, so I'll just merge when all tests pass.

hugary1995 · 2024-12-11T02:34:07Z

Urgh the clang-tidy check is unbearably slow. We need to fix it...

reverendbedford · 2024-12-11T05:24:25Z

Don't merge yet, I haven't rerun the stochastic example to make sure I got all the changing things.

hugary1995

Let's not add nbdime, pyro, and tqdm as a global dependency, as they bring in a fair number of packages.

requirements.txt

python/examples/README.md

hugary1995

My final comment:

I think torch.manual_seed doesn't guarantee reproducibility in different environments. The SVI example has two stochastic aspects: training and inference. If you save the checkpoint and reload it in the notebook, the trained model should be reproducible. But then IDK how to make the inference part (i.e., sampling the posterior) truly reproducible.

reverendbedford · 2024-12-11T14:37:38Z

My final comment:

I think torch.manual_seed doesn't guarantee reproducibility in different environments. The SVI example has two stochastic aspects: training and inference. If you save the checkpoint and reload it in the notebook, the trained model should be reproducible. But then IDK how to make the inference part (i.e., sampling the posterior) truly reproducible.

Actually I think the SVI examples in pyzag are fully-reproducible by setting the random seed in torch. But we'll see in a minute.

Setup an interface to evaluate and train NEML2 models in pyzag. This also makes pyzag a dependency of this package. Includes a few examples and tests. --------- Co-authored-by: Gary Hu <[email protected]>

reverendbedford and others added 30 commits December 10, 2024 16:48

Working on basic interface

53446f8

Not working, need to figure out new bindings

3476ed8

Almost there, need some help from gary

fd2cd0a

Fixed LabeledMatrix::fill, worked around other issue

00480dd

Gary's fix for the segfault thing

2ff5c17

On to the next random error

6f537c2

Fixed the adjoint tests, in the eventuallity this gets fixed

ef5dec0

Updated adjoint tolerances

ec7cdee

Fix inference mode bug

6ccdc32

Basic working version

4730c32

Code review

7b5da10

Deterministic demo model seems to work

6faaa3d

Tensor valued parameter update doesn't take

8586e39

Nevermind

e3dccc5

Start at a test

2a7d3dd

A regularized version of linear interpolation also does not work

1f0c0a1

See what happens in the unit test ScalarLinearInterpolation1.i

c0749b0

nvmd

000b62b

Fixed test so that it runs

9d162b5

Gary is right, other vector parameters work

d215a2a

Fix interpolation AD

f460577

Simple test to demonstrate problem

325f73f

Fixed batch size thing

0793cc0

Deterministic example completed

db3441d

Everything trains

b6ead7c

Everything seems to work, maybe give a bit more work to the examples …

bc3474d

…but no more code changes should be required

Critical fix for static recovery models

f861e33

Slight tweaks to the stochastic example

397a931

Updated merge

0ed1fe8

Changed my mind on how to require pyzag

e50d0a4

Fix a test failure outside of this change

badf33b

hugary1995 requested changes Dec 10, 2024

View reviewed changes

python/neml2/pyzag/interface.py Show resolved Hide resolved

python/neml2/pyzag/interface.py Show resolved Hide resolved

Partial code review cleanup, still need to fix python issue

54cf4bf

hugary1995 added 3 commits December 10, 2024 18:59

clang-tidy

6796856

Fix python subpackage import

cda4393

Try another form of install

813b711

hugary1995 approved these changes Dec 11, 2024

View reviewed changes

I think I'm done...

0fb0df2

hugary1995 requested changes Dec 11, 2024

View reviewed changes

requirements.txt Outdated Show resolved Hide resolved

hugary1995 requested changes Dec 11, 2024

View reviewed changes

python/examples/README.md Outdated Show resolved Hide resolved

hugary1995 requested changes Dec 11, 2024

View reviewed changes

Resolve remaining code review comments by better managing dependencies

394b3c6

hugary1995 approved these changes Dec 11, 2024

View reviewed changes

reverendbedford merged commit 19b1563 into main Dec 11, 2024
34 checks passed

reverendbedford deleted the pyzag_integration_v2 branch December 11, 2024 16:34

github-actions bot added a commit that referenced this pull request Dec 11, 2024

Remove preview for PR #178

364fd31

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Integrate pyzag bindings for neml2 #178

Integrate pyzag bindings for neml2 #178

reverendbedford commented Dec 10, 2024

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

hugary1995 left a comment

hugary1995 left a comment

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

hugary1995 left a comment

hugary1995 commented Dec 11, 2024

reverendbedford commented Dec 11, 2024

hugary1995 left a comment

hugary1995 left a comment

reverendbedford commented Dec 11, 2024

Integrate pyzag bindings for neml2 #178

Integrate pyzag bindings for neml2 #178

Conversation

reverendbedford commented Dec 10, 2024

github-actions bot commented Dec 10, 2024 • edited Loading

Test Results (ubuntu-latest-Debug-ON)

github-actions bot commented Dec 10, 2024 • edited Loading

github-actions bot commented Dec 10, 2024 • edited Loading

Test Results (macos-latest-Debug-OFF)

github-actions bot commented Dec 10, 2024 • edited Loading

Test Results (macos-latest-Release-OFF)

github-actions bot commented Dec 10, 2024 • edited Loading

Test Results (ubuntu-latest-Release-OFF)

hugary1995 left a comment

Choose a reason for hiding this comment

hugary1995 left a comment

Choose a reason for hiding this comment

github-actions bot commented Dec 11, 2024 • edited Loading

Test Results (ubuntu-latest-Debug-OFF)

github-actions bot commented Dec 11, 2024 • edited Loading

Python Binding Test Results (macos-latest)

github-actions bot commented Dec 11, 2024 • edited Loading

Python Binding Test Results (ubuntu-latest)

hugary1995 left a comment

Choose a reason for hiding this comment

hugary1995 commented Dec 11, 2024

reverendbedford commented Dec 11, 2024

hugary1995 left a comment

Choose a reason for hiding this comment

hugary1995 left a comment

Choose a reason for hiding this comment

reverendbedford commented Dec 11, 2024

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 10, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading

github-actions bot commented Dec 11, 2024 •

edited

Loading